tree 9b8e1fc0d90f109ff910b8326f5cfb9a0feb00fd
parent 7edb3a6b928b2b4faa8b9592750c58106e120940
author Sameer Agarwal <sameeragarwal@google.com> 1538786606 -0700
committer Sameer Agarwal <sameeragarwal@google.com> 1539194173 -0700

Add ParameterBlock::IsSetConstantByUser()

Introduce IsSetConstantByUser method which indicates whether
the user set the parameter block constant or not.

Changed the definition of IsConstant() to indicate if the
parameter block is effectively constant or not, which is
now the uniion of two conditions - the user set it to be constant
or the local tangent space is of size zero. Currently
this change has no effect as we do not allow local parameterizations
with zero tangent space size, but thats an inconsistency we are
working on fixing.

A variety of code cleans up to parameter_block.h

1. Remove an old TODO comment which is not really actionable.
2. Remove Init() method.
3. NULL -> nullptr
4. memcpy -> std::copy

Change-Id: I12973ee0f053fa22f09908cf36e9aa57d9d8dd74