)]}'
{
  "commit": "159815797bc7307f2d53605ab25900aecce1449f",
  "tree": "43ed3193d52756172de4aadf27de8baeeb2e547b",
  "parents": [
    "9631c693542b95c4fa5a93dfb99dcf41e03bcab8"
  ],
  "author": {
    "name": "Sameer Agarwal",
    "email": "sameeragarwal@google.com",
    "time": "Sat Nov 29 21:19:43 2014 -0800"
  },
  "committer": {
    "name": "Sameer Agarwal",
    "email": "sameeragarwal@google.com",
    "time": "Sun Nov 30 13:51:50 2014 -0800"
  },
  "message": "Do not try the gradient step if TR step line search fails.\n\nThe line search used by the trust region minimizer when enforcing\nthe bounds constraints starts by using the trust region step\nas the line search direction and if that fails, uses the gradient\nas the fallback.\n\nThe problem with this logic is that the calling code only sees\nwhether one of the line searches succeeds or not. It does not see\nthat the fallback happened. So if the fallback line search suceeeds\nit still thinks that the line search direction was the trust region\nstep. This is clearly wrong.\n\nThis change, removes the broken fallback logic. This has no effect\non current solution quality as it stands.\n\nChange-Id: Ibc8edd98f77c782ec4708d1e66eaa76d6867b990\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2f81fcb6ed08da8984ad36b7ae1a26d95516ccea",
      "old_mode": 33188,
      "old_path": "internal/ceres/trust_region_minimizer.cc",
      "new_id": "605284da1dcb7e89f5d513cb39e9a277a80df404",
      "new_mode": 33188,
      "new_path": "internal/ceres/trust_region_minimizer.cc"
    }
  ]
}
