)]}' { "commit": "29888185a1427ffcc03a228a82432944c12aa530", "tree": "a24355949b1328fae2267fe680d5237f0cd0d46f", "parents": [ "d38e49a6cc45e4bb908d46d5981c04fc2054d7b9" ], "author": { "name": "Alex Stewart", "email": "alexs.mac@gmail.com", "time": "Sat Nov 12 18:36:28 2016 +0000" }, "committer": { "name": "Alex Stewart", "email": "alexs.mac@gmail.com", "time": "Sun Nov 20 19:44:46 2016 +0000" }, "message": "Make gflags a public dependency of Ceres if it and glog are found.\n\n- Previously we were not listing gflags as a public dependency of Ceres\n if it and glog were found (and MINIGLOG was not being used). This\n does not reflect that if glog was compiled with gflags then it will\n #include gflags/gflags.h in glog/logging.h, thus making gflags a\n public dependency of anything linking against glog.\n- On *nix OSs if glog/gflags are shared libraries this did not result\n in a link error when compiling Ceres as the gflags symbols were\n indirectly resolved. However, on MSVC this is not the case, and this\n could result in unresolved gflags symbol link errors when compiling\n Ceres.\n- Now we add gflags to the list of public Ceres dependencies if both\n glog and gflags are found (and MINIGLOG is not enabled).\n\nChange-Id: I5ce6038fa816781cc81b378522068dc563d29c51\n", "tree_diff": [ { "type": "modify", "old_id": "97a1726641e50018affffd57681b0be6f1fb43f4", "old_mode": 33188, "old_path": "CMakeLists.txt", "new_id": "89d0bf035fa99ac73768b87f3a4627244f85e686", "new_mode": 33188, "new_path": "CMakeLists.txt" }, { "type": "modify", "old_id": "b589b458c7151c6bffb81c36a9f5590b5e291924", "old_mode": 33188, "old_path": "examples/CMakeLists.txt", "new_id": "eef5e5e127b754e427308e2ef8dd930350e94dc5", "new_mode": 33188, "new_path": "examples/CMakeLists.txt" }, { "type": "modify", "old_id": "c352e0ef75c0d017e2571570ec1c65e31fd10124", "old_mode": 33188, "old_path": "internal/ceres/CMakeLists.txt", "new_id": "bdcbdd1174627d2afe9e8e95565f30339e33b776", "new_mode": 33188, "new_path": "internal/ceres/CMakeLists.txt" } ] }