)]}' { "commit": "33dd469a53383743af00a711a6a85e64c35177e8", "tree": "2216c6e41f3f8804c998455f573eba1223dc2d63", "parents": [ "47e784bb4146da52d3b0695877326d60c36ab189" ], "author": { "name": "NeroBurner", "email": "pyro4hell@gmail.com", "time": "Tue Dec 03 10:05:15 2019 +0100" }, "committer": { "name": "NeroBurner", "email": "pyro4hell@gmail.com", "time": "Thu Dec 12 14:56:00 2019 +0100" }, "message": "Use Eigen3::Eigen target\n\nSince version 3.3 Eigen provides Eigen3Config.cmake with the imported\ntarget Eigen3::Eigen. [1]\nUse this imported target as descibed in Eigen-Wiki [2]\n\nIn the CeresConfig file improve relocatability by removing absolute\npaths to the compiled dependencies. Instead find the used Eigen3::Eigen.\nFurthermore use the find_dependency() [4] CMake function instead of the\nfind_package() call in CeresConfig.\n\nThis commit relies on all targets to be explicitly linked private or\npublic as done in the the change [3]\n\n[1] https://bitbucket.org/eigen/eigen/pull-requests/257/cmake-imported-target-take-2/diff\n[2] https://eigen.tuxfamily.org/dox/TopicCMakeGuide.html\n[3] https://ceres-solver-review.googlesource.com/c/ceres-solver/+/16220\n[4] https://cmake.org/cmake/help/latest/module/CMakeFindDependencyMacro.html\n\nChange-Id: I44f44a089083f7169bcf430b59775242e4eb72d1\n", "tree_diff": [ { "type": "modify", "old_id": "48d01de1d9d19169cd359b928fca251a0c432e34", "old_mode": 33188, "old_path": "CMakeLists.txt", "new_id": "c73b5f286f0d48a5d444f9a814d9b983cfd766c4", "new_mode": 33188, "new_path": "CMakeLists.txt" }, { "type": "modify", "old_id": "104e32dc9f31deb7f6002144b4c48f8011b33d59", "old_mode": 33188, "old_path": "cmake/CeresConfig.cmake.in", "new_id": "37f8d5241bdff453ad0ce65d03f733a1c714260b", "new_mode": 33188, "new_path": "cmake/CeresConfig.cmake.in" }, { "type": "delete", "old_id": "d1fa6d74dd04289db9758d9f8a6af4a875588e9b", "old_mode": 33188, "old_path": "cmake/FindEigen.cmake", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "af13f35f820d43fac9304df8f22fb51fd993dcc3", "old_mode": 33188, "old_path": "internal/ceres/CMakeLists.txt", "new_id": "cc004eea03230b175868d9bfd18fd3063b9a7022", "new_mode": 33188, "new_path": "internal/ceres/CMakeLists.txt" } ] }