tree 2d5f05705d6f8bb6ed3c81a6c9f01df39eefedfb
parent 03f8c2353b4a04678e11b2d39b839fcc6169fc95
author Sameer Agarwal <sameeragarwal@google.com> 1337269053 -0700
committer Sameer Agarwal <sameeragarwal@google.com> 1337269053 -0700

StateUpdatingCallback was being initialized with the wrong array.

StateUpdatingCallback updates the user's parameter blocks in
every iteration if the user so desires. The callback depends
on having access to an array that the minimizer is using internally
to do all the work. This is probably poor design.

As a consequence of this design, it is easy to initialize the
callback with the wrong array, which was the case here. It was
being initialized with the array of initial parameters, which the
minimizer does not touch, rather than the array final_parameters,
which just happens to the one in which the Minimizer does all
the work.

Testing this change is a pain, because nothing is wrong with the
Callback object, but rather the way it was being instantiated by
SolverImpl, and the only way to test would be to test the whole
Solve call.