)]}'
{
  "commit": "47d26bcd3b38b5ff53b34768c33b499d47b26bd0",
  "tree": "7e939bcc1ab8367f9e6b221aa15c7a452d3670f0",
  "parents": [
    "51da590c8457e6664f76fe9813425a0c71351497"
  ],
  "author": {
    "name": "Markus Moll",
    "email": "markus.moll@esat.kuleuven.be",
    "time": "Thu Aug 16 00:23:38 2012 +0200"
  },
  "committer": {
    "name": "ceres-solver code review",
    "email": "noreply-gerritcodereview@google.com",
    "time": "Fri Aug 17 13:19:14 2012 -0700"
  },
  "message": "Do not implicitly negate the step in the TrustRegionMinimizer.\n\nIn the TrustRegionMinimizer, the step is currently implicitly negated.\nThis is done so that the linearized residual is |r - J*step|^2, which\ncorresponds to J*step \u003d r, so neither J nor r have to be modified.\nHowever, it leads to the rather unintuitive situation that the strategy\nreturns a step in positive gradient direction, which you would expect to\nincrease the function value. One way is to rename the \"step\" parameter in\nthe strategy to \"negative_step\" and document it.\nThis patch instead moves the negation inside the strategy, just around\nthe linear solver call, so that it is done in a local context and easier\nto document.\n\nChange-Id: Idb258149a01f61c64e22128ea221c5a30cd89c89\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "620bda70e9282cc3eca8feffd3666c004daa1570",
      "old_mode": 33188,
      "old_path": "internal/ceres/dogleg_strategy.cc",
      "new_id": "44d484ff22184a8513643e618d6e457b49cee128",
      "new_mode": 33188,
      "new_path": "internal/ceres/dogleg_strategy.cc"
    },
    {
      "type": "modify",
      "old_id": "298748f561c8eaf24c656672ba5b975ccb41a54f",
      "old_mode": 33188,
      "old_path": "internal/ceres/levenberg_marquardt_strategy.cc",
      "new_id": "576648aba31236d69eb140137463b4148f8c2784",
      "new_mode": 33188,
      "new_path": "internal/ceres/levenberg_marquardt_strategy.cc"
    },
    {
      "type": "modify",
      "old_id": "d08255f6e1397629e81b2ec40330033e8876a49a",
      "old_mode": 33188,
      "old_path": "internal/ceres/trust_region_minimizer.cc",
      "new_id": "476cc9df1b6cb62742480fc1bc3d0d41f4565679",
      "new_mode": 33188,
      "new_path": "internal/ceres/trust_region_minimizer.cc"
    }
  ]
}