tree 83200fb9a4306afcd35fc9ff0a768c4f7d07085c
parent 0cea191d40390abce375ae615a4eab7297284622
author Sergiu Deitsch <sergiu.deitsch@gmail.com> 1696067312 +0200
committer Sergiu Deitsch <sergiu.deitsch@gmail.com> 1696073859 +0200

Rework MSVC warning suppression

Previously, MSVC warning C4996 was suppressed unconditionally in the
entire code base which made it difficult identifying and fixing specific
problems, particularly those in the public interface.

Prefer now to disable warnings at the specific location they occur. This
approach, however, reveals an inconsistency in how Ceres handles POSIX
functions which are declared deprecated by MSVC. Specifically, Bessel
functions use the underscore form whereas the read function does not. To
simplify the logic, we revert to POSIX compatible functions.

C++23 also deprecates std::numeric_limits<T>::has_denorm which MSVC
warns about. Here, we disable the deprecation warning locally to avoid
the warning leaking into the user code.

Fixes #1013

Change-Id: Ida8457cc8dd8770b4384a7c49d16f213b02cdec4