tree f9a7d568477d28496070fa47005fe3aea4d3e055
parent e81a5dd300b43591135bc150789a6641f67745e0
author Sameer Agarwal <sameeragarwal@google.com> 1415167329 -0800
committer Sameer Agarwal <sameeragarwal@google.com> 1415229907 -0800

Move gradient convergence test after step update.

The trust region minimizer was detecting convergence due to
the gradient tolerance being reached but was not updating the
step. In the unconstrained test this is usually not a problem,
since we approach this point quite slowly. In the constrained
case however, we may approach this point quite quickly as a
result of the line search.

As a consequence, even though the solver finds the optimal
solution on the boundary, it fails to return this solution
to the user.

Thanks to Rodney Hoskinson for reporting this.

Change-Id: I7b1bcd1310ef0582e05957f43d1700eaabd73241