tree 25378953115c43b51aad19d2d52073f61ad79075
parent 9f32c42ba628dfa255cb85b0d16b29e29a8e802b
author Sergiu Deitsch <sergiu.deitsch@gmail.com> 1645479812 +0100
committer Alex Stewart <alexs.mac@gmail.com> 1646265430 +0000

Store ProductManifold instances in a tuple

Since the number of manifolds used to initialize ProductManifold and
their types are known at compile-time, it is possible to avoid storing
pointers to the base class as required by a homogeneous, currently
dynamically sized container. Instead, we can use std::tuple<> as a
heterogenous container with the number of elements fixed at compile-time
that allows us to store the concrete manifold realizations.

The advantage of this approach is that we can bypass the vtable when
iterating over each manifold within ProductManifold. The indirection is
invoked only once while accessing the ProductManifoldImpl members.
Additionally, potential dynamic memory allocations by a std::vector can
be completely avoided. This makes the ProductManifold implementation
more efficient both in memory and runtime.

Change-Id: Ic71b0c175ab726f8992e9703f7666bca477baf19