)]}'
{
  "commit": "9364e31ee8dacbdd2c1689c4f74c291c5d7000f0",
  "tree": "e633f8d7dec916c96c2890afa1b94503d3b2c419",
  "parents": [
    "89b3e1f88fe548fba30759d88f5389b784165470"
  ],
  "author": {
    "name": "Sameer Agarwal",
    "email": "sameeragarwal@google.com",
    "time": "Mon Oct 31 15:01:26 2022 -0700"
  },
  "committer": {
    "name": "Sameer Agarwal",
    "email": "sameeragarwal@google.com",
    "time": "Mon Oct 31 15:03:37 2022 -0700"
  },
  "message": "Fix a regression in SuiteSparse::AnalyzeCholesky\n\nWhen AnalyzeCholesky is called on a Jacobian which has been\npre-ordered in the preprocessor, we assume a NATURAL ordering.\nIn this case, asking CHOLMOD to do a postordering is detrimental\nto the performance. This regression was introduced in\n\nhttps://github.com/ceres-solver/ceres-solver/commit/d09f7e9d5e3bfab2d7ec7e81fd6a55786edca17a\n\nbased on an email exchange with Prof. Tim Davis the author of CHOLMOD\nwho suggested that this should be innocous. Unfortunately this is not\nthe case. The following table shows the performance of bundle_adjuster\non a variety of problems. This matches the performance of the\nbundle adjuster before the CL that introduced the regression.\n\n                               Before      After\nproblem-49-7776-pre.txt\nSPARSE_NORMAL_CHOLESKY + AMD      0.8        0.6\nSPARSE_NORMAL_CHOLESKY + NESDIS   0.8        0.6\nSPARSE_SCHUR + AMD                0.1        0.1\nSPARSE_SCHUR + NESDIS             0.1        0.1\n\nproblem-1778-993923-pre.txt\nSPARSE_NORMAL_CHOLESKY + AMD    247.1      197.0\nSPARSE_NORMAL_CHOLESKY + NESDIS 234.0      193.2\nSPARSE_SCHUR + AMD               78.7       71.8\nSPARSE_SCHUR + NESDIS            78.7       71.4\n\nproblem-1031-110968-pre.txt\nSPARSE_NORMAL_CHOLESKY + AMD     26.1       22.4\nSPARSE_NORMAL_CHOLESKY + NESDIS  26.0       23.0\nSPARSE_SCHUR + AMD               14.9       13.1\nSPARSE_SCHUR + NESDIS            14.9       13.1\n\nproblem-356-226730-pre.txt\nSPARSE_NORMAL_CHOLESKY + AMD     43.9       34.7\nSPARSE_NORMAL_CHOLESKY + NESDIS  42.5       34.8\nSPARSE_SCHUR + AMD                6.8        6.1\nSPARSE_SCHUR + NESDIS             6.8        6.1\n\nproblem-951-708276-pre.txt\nSPARSE_NORMAL_CHOLESKY + AMD    170.3      139.0\nSPARSE_NORMAL_CHOLESKY + NESDIS 168.9      139.8\nSPARSE_SCHUR + AMD               52.3       47.9\nSPARSE_SCHUR + NESDIS            52.0       47.7\n\nChange-Id: I6421060dd835ab2fc81d270238f6f67e29f3ecd5\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "e108ec69425561b05e4bf10ed536cccb0715eea7",
      "old_mode": 33188,
      "old_path": "internal/ceres/suitesparse.cc",
      "new_id": "189a24f0205c72e5bd9c8af54b3ecb812b5a732f",
      "new_mode": 33188,
      "new_path": "internal/ceres/suitesparse.cc"
    }
  ]
}