tree eceea4f5b9a3756090c3e3014c9093c8b9ad03ca
parent c964fce90ce90d6fa61553d42ab1042a177ab200
author Sameer Agarwal <sameeragarwal@google.com> 1663892932 -0700
committer Sameer Agarwal <sameeragarwal@google.com> 1663892932 -0700

Restore the semantics of TrustRegionMinimizer

A previous change to fix a bug related to how x_norm was being
initialized changed the semantics of the TrustRegionMinimizer
loop. With the bug, the parameter_tolerance was being ignored
till the first successful step was encountered.

parameter_tolerance based convergence is a hack anyways, so
restoring the previous semantics is reasonable and will preserve
existing code/tests that depend on this behaviour.

Change-Id: Ia00ca6c47f77e74dee64ad746f4299a9eab0eb7e