tree 75b059c0fe14d4c70229789fdb5a9f91f49aa337
parent 8e5d83f07de2122b62738e97dfd05aafbeed233d
author Sameer Agarwal <sameeragarwal@google.com> 1671325022 -0800
committer Sameer Agarwal <sameeragarwal@google.com> 1671327123 -0800

Fix a bug in CoordinateDescentMinimizer

CoordinateDescentMinimizer optimizes one parameter block at a time.
To do this, it manipulates the parameter block object. It was doing
so inconsistently, where the tangent space offset was being set to
zero but the ambient state offset was not being set to zero. This
did not cause problems because these offsets were not really being
used inside the CoordinateDescentMinimizer. However the recent
change which parallelizes Program::Plus uncovered this bug.

The reason this bug was not caught was because, CoordinateDescentMinimizer
does not have any tests. I will fix this shortly, but in the interim
to unbreak inner iterations at head, this small change should go in.

Change-Id: I55d2698e8509f9cb5751e7a5180427129d86e720