tree 9706993a635ba028a9ab4f13bb687207f4dc1223
parent 90bbf0fb221de94e33ffd1e655baad81f07f9ee4
author Sameer Agarwal <sameeragarwal@google.com> 1378444137 -0700
committer Keir Mierle <mierle@gmail.com> 1378572322 +0000

Fix a bug in TrustRegionMinimizer.

LocalParameterization::Plus is allowed to return false when for some
reason the operation cannot be performed. Uptil now, this would
cause the TrustRegionMinimizer to terminate with a numerical failure.

This is not correct behaviour. Just like CostFunction::Evaluate,
returning false from LocalParameterization::Plus should result
in the current step to be rejected rather than the entire optimization
coming to a halt.

LineSearchMinimizer has also been updated to use the same pattern.

Thanks to Michael Vitus for reporting this.

Change-Id: I1351966bc6db3bf6cd46387b78d4e52a9df51696