tree 02ef289090b8f84e22e6e3885cb2e024e43b0bb5
parent af3b9394ea577165bedd81315c6a9998fd91c6e5
author Sameer Agarwal <sameeragarwal@google.com> 1489908862 -0700
committer Sameer Agarwal <sameeragarwal@google.com> 1489909081 -0700

Fix when LineSearchMinimizer adds the IterationSummary to Solver::Summary

Previously, even when an iteration was successful, the LineSearchMinimizer
would only add the iteration summary to the Summary object if none
of the convergence tests were passed. This could cause iterations with
significant progress in the last iteration to be mis-reported.

The solution would be correct, but the actual cost would be misreported.

This change changes the order of these operations and ensures that
the iteration summary is added whenever the iteration itself is successful.

Thanks to Daniel Weindl for reporting this.

Change-Id: Iff10eccb49d50ad28127f44e149c17fa466db4ae