commit 0b5df70e33e7c9d64b3d9b90e21d1d1edd96e4a8
author Sameer Agarwal <sameeragarwal@google.com> Wed Nov 28 15:53:07 2012 -0800
committer Sameer Agarwal <sameeragarwal@google.com> Wed Nov 28 15:53:07 2012 -0800
tree 39842bdf50d89551012119785315f53869e6803b
parent 86f6ea68b83bc7b783c2f842db2ad8f982ee69d1

Bug fix in solver_impl_test.

One of the tests CreateLinearSolverNoSuiteSparse, fails
when no sparse backend is present. This was a failure
in running tests with all possible sparse backend settings.

Thanks to Sebastian Fabbro for reporting this.

Change-Id: I0ab98632ae7dd33f18d67cb9f490e74c034ce03d

internal/ceres/solver_impl_test.cc

diff --git a/internal/ceres/solver_impl_test.cc b/internal/ceres/solver_impl_test.cc
index 5eb6c66..d918a57 100644
--- a/internal/ceres/solver_impl_test.cc
+++ b/internal/ceres/solver_impl_test.cc
@@ -499,6 +499,8 @@
 TEST(SolverImpl, CreateLinearSolverNoSuiteSparse) {
   Solver::Options options;
   options.linear_solver_type = SPARSE_NORMAL_CHOLESKY;
+  // CreateLinearSolver assumes a non-empty ordering.
+  options.linear_solver_ordering = new ParameterBlockOrdering;
   string error;
   EXPECT_FALSE(SolverImpl::CreateLinearSolver(&options, &error));
 }