commit 195d8d13a6a3962ac39ef7fcdcc6add0216eb8bc
author Sameer Agarwal <sameeragarwal@google.com> Tue Sep 06 07:12:23 2016 -0700
committer Sameer Agarwal <sameeragarwal@google.com> Tue Sep 06 07:15:20 2016 -0700
tree a21461014c9c9f4daa36ef73cd900ae2f42aed2d
parent 83041ac84f2d67c28559c67515e0e596a3f3aa20

Remove two DCHECKs from CubicHermiteSpline.

They were present as debugging checks but were causing problems
with the build on 32bit i386 due to numerical cancellation issues,
where x ~ -epsilon.

Removing these checks only changes the behaviour in Debug mode.
We are already handling such small negative numbers in production
if they occur. All that this change does is to remove the crash.

https://github.com/ceres-solver/ceres-solver/issues/212

Thanks to @NeroBurner and @debalance for reporting this.

Change-Id: I66480e86d4fa0a4b621204f2ff44cc3ff8d01c04

include/ceres/cubic_interpolation.h

diff --git a/include/ceres/cubic_interpolation.h b/include/ceres/cubic_interpolation.h
index 41bf627..53bbc33 100644
--- a/include/ceres/cubic_interpolation.h
+++ b/include/ceres/cubic_interpolation.h
@@ -69,8 +69,6 @@
                         const double x,
                         double* f,
                         double* dfdx) {
-  DCHECK_GE(x, 0.0);
-  DCHECK_LE(x, 1.0);
   typedef Eigen::Matrix<double, kDataDimension, 1> VType;
   const VType a = 0.5 * (-p0 + 3.0 * p1 - 3.0 * p2 + p3);
   const VType b = 0.5 * (2.0 * p0 - 5.0 * p1 + 4.0 * p2 - p3);