commit 33e01b9c5e1416fe29c55ac0332cdca21c053c83
author Sameer Agarwal <sameeragarwal@google.com> Wed Nov 27 10:24:03 2013 -0800
committer Sameer Agarwal <sameeragarwal@google.com> Wed Nov 27 10:24:03 2013 -0800
tree 1a90f8aacc2e72fe8ec978243292970727b2c336
parent 068437eb89d495d905465544ccd442efef457b04

Rename LinearSolverTerminationType enums.

This increases clarity, drops redundant enums and makes things
cleaner all around.

Change-Id: I761f195ddf17ea6bd8e4e55bf5a72863660c4c3b

internal/ceres/linear_solver.h

diff --git a/internal/ceres/linear_solver.h b/internal/ceres/linear_solver.h
index fa151e0..cb26356 100644
--- a/internal/ceres/linear_solver.h
+++ b/internal/ceres/linear_solver.h
@@ -51,26 +51,19 @@
 namespace internal {
 
 enum LinearSolverTerminationType {
-  // Termination criterion was met. For factorization based solvers
-  // the tolerance is assumed to be zero. Any user provided values are
-  // ignored.
-  TOLERANCE,
+  // Termination criterion was met.
+  LINEAR_SOLVER_SUCCESS,
 
   // Solver ran for max_num_iterations and terminated before the
-  // termination tolerance could be satified.
-  MAX_ITERATIONS,
+  // termination tolerance could be satisfied.
+  LINEAR_SOLVER_NO_CONVERGENCE,
 
-  // Solver is stuck and further iterations will not result in any
-  // measurable progress.
-  STAGNATION,
-
-  // Solver failed. Solver was terminated due to numerical errors. The
-  // exact cause of failure depends on the particular solver being
-  // used.
-  FAILURE,
+  // Solver was terminated due to numerical problems, generally due to
+  // the linear system being poorly conditioned.
+  LINEAR_SOLVER_FAILURE,
 
   // Solver failed with a fatal error that cannot be recovered from.
-  FATAL_ERROR
+  LINEAR_SOLVER_FATAL_ERROR
 };
 
 
@@ -267,7 +260,7 @@
     Summary()
         : residual_norm(0.0),
           num_iterations(-1),
-          termination_type(FAILURE) {
+          termination_type(LINEAR_SOLVER_FAILURE) {
     }
 
     double residual_norm;