commit | 523e397be2c7820e2b1979886eaad2df9b466d40 | [log] [tgz] |
---|---|---|
author | Alex Stewart <alexs.mac@gmail.com> | Mon Nov 21 11:56:19 2016 +0000 |
committer | Alex Stewart <alexs.mac@gmail.com> | Mon Nov 21 11:56:19 2016 +0000 |
tree | d71a3e81c38e7a33db01f049daeece5c61e1dfde | |
parent | 0f80f018ffa4f9885e487f5d2e492ff94905a6e0 [diff] |
Fix missing gflags imported target definition in CeresConfig.cmake - If gflags was built & exported with CMake but glog was not, but both were found then as we now make gflags a public dependency of Ceres if both it and glog are found, the *name* of the exported gflags CMake target (gflags-shared or similar) will appear in CERES_LIBRARIES. - However, as imported targets are not re-exported, this results in a linker error when compiling client code, as the name of the exported gflags target is not known to CMake, it assumes it is a library name, which it is not. - Confusingly, if glog was built with CMake, this problem would not occur, as in that case glog’s CMake target would bring in gflags’. - Now we explicitly call find_package(Gflags) in CeresConfig.cmake if Ceres was built with gflags as a public dependency (via glog). Change-Id: I5cc9483a1fae50f4e9e3a8fbba491b645fd45db6
Ceres Solver is an open source C++ library for modeling and solving large, complicated optimization problems. It is a feature rich, mature and performant library which has been used in production at Google since 2010. Ceres Solver can solve two kinds of problems.
Please see ceres-solver.org for more information.
Ceres development happens on Gerrit, including both repository hosting and code reviews. The GitHub Repository is a continuously updated mirror which is primarily meant for issue tracking. Please see our Contributing to Ceres Guide for more details.
The upstream Gerrit repository is
https://ceres-solver.googlesource.com/ceres-solver