Fix the Bazel build Fixes https://github.com/ceres-solver/ceres-solver/issues/893 Change-Id: I95802354bc8a00848573c564fe75c5e87ddf8fae
diff --git a/BUILD b/BUILD index 20f1d0a..db5b090 100644 --- a/BUILD +++ b/BUILD
@@ -72,7 +72,6 @@ CERES_TESTS = [ "array_utils", "autodiff_cost_function", - "autodiff_local_parameterization", "autodiff_manifold", "autodiff", "block_jacobi_preconditioner", @@ -120,7 +119,6 @@ "levenberg_marquardt_strategy", "line_search_minimizer", "line_search_preprocessor", - "local_parameterization", "loss_function", "minimizer", "normal_prior", @@ -167,10 +165,6 @@ # but in the future disable these warnings only for rotation_test. # TODO(keir): When the tests are macro-ified, apply these selectively. "-Wno-address", - - # Disable warnings about deprecated interfraces while we are - # transitioning from LocalParameterization to Manifolds. - "-Wno-deprecated-declarations", ] TEST_DEPS = [
diff --git a/CMakeLists.txt b/CMakeLists.txt index b1fcddd..b5d0efe 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt
@@ -613,12 +613,6 @@ endif(HAVE_RETURN_TYPE_C_LINKAGE) endif () -# Disable warnings about deprecated interfaces while we are -# transitioning from LocalParameterization to Manifolds. -add_compile_options( - $<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:-Wno-deprecated-declarations> - $<$<CXX_COMPILER_ID:MSVC>:/wd4996>) - if (CMAKE_VERSION VERSION_LESS 3.12) # Disable the definition of min/max macros within the project if (WIN32)
diff --git a/bazel/ceres.bzl b/bazel/ceres.bzl index 0fa2d43..46e100d 100644 --- a/bazel/ceres.bzl +++ b/bazel/ceres.bzl
@@ -48,7 +48,6 @@ "compressed_row_jacobian_writer.cc", "compressed_row_sparse_matrix.cc", "conditioned_cost_function.cc", - "conjugate_gradients_solver.cc", "context.cc", "context_impl.cc", "coordinate_descent_minimizer.cc", @@ -189,10 +188,6 @@ copts = [ "-I" + internal, "-Wno-sign-compare", - - # Disable warnings about deprecated interfaces while we are - # transitioning from LocalParameterization to Manifolds. - "-Wno-deprecated-declarations", ] + schur_eliminator_copts, # These include directories and defines are propagated to other targets
diff --git a/internal/ceres/parallel_for_cxx.h b/internal/ceres/parallel_for_cxx.h index 90edc07..b745a64 100644 --- a/internal/ceres/parallel_for_cxx.h +++ b/internal/ceres/parallel_for_cxx.h
@@ -181,7 +181,6 @@ if (thread_id >= num_threads) return; const int start = shared_state->start; - const int end = shared_state->end; const int base_block_size = shared_state->base_block_size; const int num_base_p1_sized_blocks = shared_state->num_base_p1_sized_blocks; const int num_work_blocks = shared_state->num_work_blocks;