commit 6196cba4e50dc02187dcd5bff7b5929ebc080687
author Keir Mierle <mierle@gmail.com> Mon Jun 18 11:03:40 2012 -0700
committer Keir Mierle <mierle@gmail.com> Tue Jun 19 00:09:53 2012 -0700
tree 36bb3c0738a93520aa87c6e8f94401937987dd5d
parent 4df0b7c208b8847c9db8f42254c8401961453cb0

Fix broken constant parameter blocks

This fixes the bug introduced in a previous commit,
and adds a test to check that constant parameter
blocks work as expected.

This also refactors the Solver/SolverImpl split so
that SolverImpl is no longer a friend of Problem;
instead, Solver is. This makes it possible to
verify the invariant on parameter block states in
the unit test, and is a more symmetric design
anyway.

Bug: 51
Change-Id: Id503f5b526cfb8bc24aae3aaad2e414b14063d78

internal/ceres/program.cc

diff --git a/internal/ceres/program.cc b/internal/ceres/program.cc
index 529e4a3..3d62272 100644
--- a/internal/ceres/program.cc
+++ b/internal/ceres/program.cc
@@ -90,7 +90,7 @@
   }
 }
 
-bool Program::CopyUserStateToParameterBlocks() {
+bool Program::SetParameterBlockStatePtrsToUserStatePtrs() {
   for (int i = 0; i < parameter_blocks_.size(); ++i) {
     if (!parameter_blocks_[i]->SetState(parameter_blocks_[i]->user_state())) {
       return false;