commit | 860bba588b981a5718f6b73e7e840e5b8757fe65 | [log] [tgz] |
---|---|---|
author | Sameer Agarwal <sameeragarwal@google.com> | Tue Aug 25 09:43:21 2015 -0700 |
committer | Sameer Agarwal <sameeragarwal@google.com> | Tue Aug 25 11:14:10 2015 -0700 |
tree | 57456f0db58b1c426ded7412cafb9fbb90147fe8 | |
parent | b0cbc0f0b0a22f01724b7b647a4a94db959cc4e4 [diff] |
Fix a bug in DetectStructure The logic for determing static/dynamic f-block size in DetectStructure was broken in a corner case, where the very first row block which was used to initialize the f_block_size contained more than one f blocks of varying sizes. The way the if block was structured, no iteration was performed on the remaining f-blocks and the loop failed to detect that the f-block size was actually changing. If in the remaining row blocks, there were no row blocks with varying f-block sizes, the function will erroneously return a static f-block size. Thanks to Johannes Schonberger for providing a reproduction for this rather tricky corner case. Change-Id: Ib442a041d8b7efd29f9653be6a11a69d0eccd1ec
Please see ceres-solver.org for more information.
Ceres development happens on Gerrit, including both repository hosting and code reviews. The GitHub Repository is a continuously updated mirror which is primarily meant for issue tracking. Please see our Contributing to Ceres Guide for more details.
The upstream Gerrit repository is
https://ceres-solver.googlesource.com/ceres-solver