commit b01f19840894fa39673d939b1f17003d863278db
author Sameer Agarwal <sameeragarwal@google.com> Thu May 10 12:18:39 2012 -0700
committer Sameer Agarwal <sameeragarwal@google.com> Thu May 10 12:18:39 2012 -0700
tree 8729864ed06a120a7543189f63938547cbd38be7
parent 0e99e9c02cb195543dd1b6e7ee1644754b8909a8

Replace EXPECT_EQ for floating point comparisons with EXPECT_NEAR

internal/ceres/local_parameterization_test.cc

diff --git a/internal/ceres/local_parameterization_test.cc b/internal/ceres/local_parameterization_test.cc
index 26a57c1..8315e8e 100644
--- a/internal/ceres/local_parameterization_test.cc
+++ b/internal/ceres/local_parameterization_test.cc
@@ -152,6 +152,7 @@
 void QuaternionParameterizationTestHelper(const double* x,
                                           const double* delta,
                                           const double* q_delta) {
+  const double kTolerance = 1e-14;
   double x_plus_delta_ref[4] = {0.0, 0.0, 0.0, 0.0};
   QuaternionProduct(q_delta, x, x_plus_delta_ref);
 
@@ -159,7 +160,7 @@
   QuaternionParameterization param;
   param.Plus(x, delta, x_plus_delta);
   for (int i = 0; i < 4; ++i) {
-    EXPECT_EQ(x_plus_delta[i], x_plus_delta_ref[i]);
+    EXPECT_NEAR(x_plus_delta[i], x_plus_delta_ref[i], kTolerance);
   }
 
   const double x_plus_delta_norm =
@@ -168,7 +169,7 @@
            x_plus_delta[2] * x_plus_delta[2] +
            x_plus_delta[3] * x_plus_delta[3]);
 
-  EXPECT_NEAR(x_plus_delta_norm, 1.0, 1e-12);
+  EXPECT_NEAR(x_plus_delta_norm, 1.0, kTolerance);
 
   double jacobian_ref[12];
   double zero_delta[3] = {0.0, 0.0, 0.0};
@@ -183,7 +184,7 @@
   param.ComputeJacobian(x, jacobian);
   for (int i = 0; i < 12; ++i) {
     EXPECT_TRUE(isfinite(jacobian[i]));
-    EXPECT_NEAR(jacobian[i], jacobian_ref[i], 1e-12)
+    EXPECT_NEAR(jacobian[i], jacobian_ref[i], kTolerance)
         << "Jacobian mismatch: i = " << i
         << "\n Expected \n" << ConstMatrixRef(jacobian_ref, 4, 3)
         << "\n Actual \n" << ConstMatrixRef(jacobian, 4, 3);