commit cbf03ac292a0c0e9e6b7fcc1b08b67e95965922f
author Sameer Agarwal <sameeragarwal@google.com> Sat Sep 06 21:07:08 2014 -0700
committer Sameer Agarwal <sameeragarwal@google.com> Sun Sep 07 18:39:00 2014 -0700
tree cd5cb559d06ce53372ac4cc1f8d2053c182d1168
parent f04c32319751e1efd610acd3699bca0a6dd6c6d1

Make LineSearchMinimizer consistent with TrustRegionMinimizer.

Change the logic for how IterationSummary objects are added to
Summary::iterations to match the one in TrustRegionMinimizer.

Change-Id: I57851ad8294e58f83b9115cca9c24695d86ee92a

internal/ceres/line_search_minimizer.cc

diff --git a/internal/ceres/line_search_minimizer.cc b/internal/ceres/line_search_minimizer.cc
index f494eda..ad28ffb 100644
--- a/internal/ceres/line_search_minimizer.cc
+++ b/internal/ceres/line_search_minimizer.cc
@@ -375,7 +375,6 @@
         WallTimeInSeconds() - start_time
         + summary->preprocessor_time_in_seconds;
 
-    summary->iterations.push_back(iteration_summary);
     ++summary->num_successful_steps;
 
     if (iteration_summary.gradient_max_norm <= options.gradient_tolerance) {
@@ -401,6 +400,8 @@
       VLOG_IF(1, is_not_silent) << "Terminating: " << summary->message;
       break;
     }
+
+    summary->iterations.push_back(iteration_summary);
   }
 }