commit d500caacebb044952113cae733ed92c645aa457b
author Sameer Agarwal <sameeragarwal@google.com> Thu Apr 09 21:05:22 2015 -0700
committer Sameer Agarwal <sameeragarwal@google.com> Thu Apr 09 21:05:22 2015 -0700
tree 625b223ed7042e42df001b6d04b2d55c9184ac7f
parent e712ce1810cf7ec80f58f3998d4091445f5fa906

Remove confusing code from DenseJacobianWriter

The code seemed to imply that its possible to call the Write
method with a null pointer which is never the case. There would
be no point to calling Write.

Thanks to Michael Vitus for pointing this out.

Change-Id: Ic9a276856d0a7e65d53a1cc8742d4831c1a52615

internal/ceres/dense_jacobian_writer.h

diff --git a/internal/ceres/dense_jacobian_writer.h b/internal/ceres/dense_jacobian_writer.h
index a0fec3f..1b04f38 100644
--- a/internal/ceres/dense_jacobian_writer.h
+++ b/internal/ceres/dense_jacobian_writer.h
@@ -70,10 +70,7 @@
              int residual_offset,
              double **jacobians,
              SparseMatrix* jacobian) {
-    DenseSparseMatrix* dense_jacobian;
-    if (jacobian != NULL) {
-      dense_jacobian = down_cast<DenseSparseMatrix*>(jacobian);
-    }
+    DenseSparseMatrix* dense_jacobian = down_cast<DenseSparseMatrix*>(jacobian);
     const ResidualBlock* residual_block =
         program_->residual_blocks()[residual_id];
     int num_parameter_blocks = residual_block->NumParameterBlocks();