commit e7148795c3f2ce1f6625a7c81545707a6cbde3eb
author Sameer Agarwal <sameeragarwal@google.com> Mon Mar 04 10:17:30 2013 -0800
committer Sameer Agarwal <sameeragarwal@google.com> Mon Mar 04 13:30:09 2013 -0800
tree 9b07858f2dbfc24596684ca2da9916b835c2cf32
parent 480f9b8551c02c429bc027197f3d868c5cc522c9

Fix a memory leak in CXSparse::SolveCholesky.

Thanks to Alexander Mordvintsev for reporting this.

Change-Id: I5c6be4d3d28f062e83a1ad41cb8089c19362a005

internal/ceres/cxsparse.cc

diff --git a/internal/ceres/cxsparse.cc b/internal/ceres/cxsparse.cc
index 19fa17c..3fbc271 100644
--- a/internal/ceres/cxsparse.cc
+++ b/internal/ceres/cxsparse.cc
@@ -57,6 +57,7 @@
       cs_free(scratch_);
     }
     scratch_ = reinterpret_cast<CS_ENTRY*>(cs_malloc(A->n, sizeof(CS_ENTRY)));
+    scratch_size_ = A->n;
   }
 
   // Solve using Cholesky factorization

internal/ceres/trust_region_minimizer_test.cc

diff --git a/internal/ceres/trust_region_minimizer_test.cc b/internal/ceres/trust_region_minimizer_test.cc
index ffa2317..52d682d 100644
--- a/internal/ceres/trust_region_minimizer_test.cc
+++ b/internal/ceres/trust_region_minimizer_test.cc
@@ -370,7 +370,7 @@
   EXPECT_LE(summary.final_cost, 1e-10);
 
   for (int i = 0; i < N; i++) {
-    delete y[i];
+    delete []y[i];
   }
 }