Fix double conversion to degrees in rotation_test Change-Id: I16b6d210cdab94340c001b322916c5b1a3b6a35f
diff --git a/internal/ceres/rotation_test.cc b/internal/ceres/rotation_test.cc index 4167d71..7f6e829 100644 --- a/internal/ceres/rotation_test.cc +++ b/internal/ceres/rotation_test.cc
@@ -616,9 +616,10 @@ } // Convert Euler angles from radians to degrees. -static void ToDegrees(double ea[3]) { - for (int i = 0; i < 3; ++i) - ea[i] *= 180.0 / kPi; +static void ToDegrees(double euler_angles[3]) { + for (int i = 0; i < 3; ++i) { + euler_angles[i] *= 180.0 / kPi; + } } // Compare the 3x3 rotation matrices produced by the axis-angle @@ -662,13 +663,13 @@ TEST(EulerAnglesToRotationMatrix, IsOrthonormal) { srand(5); for (int trial = 0; trial < kNumTrials; ++trial) { - double ea[3]; - for (int i = 0; i < 3; ++i) - ea[i] = 360.0 * (RandDouble() * 2.0 - 1.0); - double ea_matrix[9]; - ToDegrees(ea); // Radians to degrees. - EulerAnglesToRotationMatrix(ea, 3, ea_matrix); - EXPECT_THAT(ea_matrix, IsOrthonormal()); + double euler_angles_degrees[3]; + for (int i = 0; i < 3; ++i) { + euler_angles_degrees[i] = RandDouble() * 360.0 - 180.0; + } + double rotation_matrix[9]; + EulerAnglesToRotationMatrix(euler_angles_degrees, 3, rotation_matrix); + EXPECT_THAT(rotation_matrix, IsOrthonormal()); } } @@ -697,7 +698,6 @@ return j; } - bool IsClose(double x, double y) { EXPECT_FALSE(IsNaN(x)); EXPECT_FALSE(IsNaN(y));