commit f747183ec022f06d9828cfc909dcd50edebe5789
author Keir Mierle <mierle@gmail.com> Thu Jun 14 11:31:53 2012 -0700
committer Keir Mierle <mierle@gmail.com> Mon Jun 18 00:49:58 2012 -0700
tree a228e2f6a12331371423512b691c5123855975b7
parent 57d91f5e9eafd8e89c473d7e92175eaa5ae75276

Fix user iteration callbacks.

User callbacks got broken at some point due to the extra
layer of copying from Solver::Options to Minimizer::Options.
This copies the user callbacks when initializing
Minimizer::Options from Solver::Options, and adds a test to
this effect.

This also fixes a bug where the state updating callback was
not called before the user callbacks. This also adds a test
to solver_impl_test to ensure the state updating callbacks
work as expected.

Thanks to Luis Alberto Zarrabeitia for the report.

Issue: 46
Change-Id: I2b36415c89dafaa5c84ecaa727a325df122e1092

internal/ceres/minimizer.h

diff --git a/internal/ceres/minimizer.h b/internal/ceres/minimizer.h
index e15b165..70b530f 100644
--- a/internal/ceres/minimizer.h
+++ b/internal/ceres/minimizer.h
@@ -78,6 +78,7 @@
       evaluator = NULL;
       trust_region_strategy = NULL;
       jacobian = NULL;
+      callbacks = options.callbacks;
     }
 
     int max_num_iterations;