| commit | 12eb389b4ec4113a2260c1a192a1d3f8d1b6a2d3 | [log] [tgz] |
|---|---|---|
| author | Sameer Agarwal <sameeragarwal@google.com> | Wed Aug 27 22:18:33 2014 -0700 |
| committer | Keir Mierle <mierle@gmail.com> | Thu Aug 28 16:34:22 2014 +0000 |
| tree | f835233316a60053928a388247c04d935fd0f17a | |
| parent | 6c25185bb1643d8d0f3d8e1a7b82a058156aa869 [diff] |
Fix Eigen Row/ColMajor bug in NumericDiffCostFunction. If the parameter block size is 1, asking Eigen to create a row-major matrix triggers a compile time error. Previously we were handling the case where the number of rows in the jacobian block was known statically, but the problem is present when the nummber of rows is dynamic. This CL fixes this problem. Thanks to Dominik Reitzle for reporting this. Change-Id: I99c3eec3558e66ebf4efa51c4dee8ce292ffe0c1