commit 22aeb3584391556d06c546d67c86f2c6557b801c
author Sameer Agarwal <sameeragarwal@google.com> Mon Aug 15 22:16:43 2022 -0700
committer Sameer Agarwal <sameeragarwal@google.com> Mon Aug 15 22:16:43 2022 -0700
tree 80937ee3333cb0cf8af60e22c5ba4f935c8db6ef
parent 3b891f767264e2393ecf2605747ac6124058320d

Fix a missing string assignment in solver.cc

Change-Id: I3dfc28603c6af10f361ca4877f518a5f28edfdbd

internal/ceres/solver.cc

diff --git a/internal/ceres/solver.cc b/internal/ceres/solver.cc
index e947e06..84487bb 100644
--- a/internal/ceres/solver.cc
+++ b/internal/ceres/solver.cc
@@ -345,14 +345,16 @@
   // Check options for CGNR with CUDA_SPARSE.
   if (options.sparse_linear_algebra_library_type == CUDA_SPARSE) {
     if (!IsSparseLinearAlgebraLibraryTypeAvailable(CUDA_SPARSE)) {
-      *error = "Can't use CGNR with sparse_linear_algebra_library_type = "
+      *error =
+          "Can't use CGNR with sparse_linear_algebra_library_type = "
           "CUDA_SPARSE because support was not enabled when Ceres was built.";
       return false;
     }
     if (options.preconditioner_type != IDENTITY) {
-      StringPrintf("Can't use CGNR with preconditioner_type = %s when "
-                   "sparse_linear_algebra_library_type = CUDA_SPARSE.",
-                    PreconditionerTypeToString(options.preconditioner_type));
+      *error = StringPrintf(
+          "Can't use CGNR with preconditioner_type = %s when "
+          "sparse_linear_algebra_library_type = CUDA_SPARSE.",
+          PreconditionerTypeToString(options.preconditioner_type));
       return false;
     }
   }
@@ -907,14 +909,14 @@
         linear_solver_type_used == SPARSE_SCHUR ||
         linear_solver_type_used == CGNR ||
         (linear_solver_type_used == ITERATIVE_SCHUR &&
-            (preconditioner_type_used == CLUSTER_JACOBI ||
-            preconditioner_type_used == CLUSTER_TRIDIAGONAL));
+         (preconditioner_type_used == CLUSTER_JACOBI ||
+          preconditioner_type_used == CLUSTER_TRIDIAGONAL));
 
     const bool linear_solver_ordering_required =
         linear_solver_type_used == SPARSE_SCHUR ||
         (linear_solver_type_used == ITERATIVE_SCHUR &&
-            (preconditioner_type_used == CLUSTER_JACOBI ||
-            preconditioner_type_used == CLUSTER_TRIDIAGONAL)) ||
+         (preconditioner_type_used == CLUSTER_JACOBI ||
+          preconditioner_type_used == CLUSTER_TRIDIAGONAL)) ||
         (linear_solver_type_used == CGNR && preconditioner_type_used == SUBSET);
 
     if (used_sparse_linear_algebra_library) {
@@ -929,12 +931,11 @@
             LinearSolverOrderingTypeToString(linear_solver_ordering_type),
             mixed_precision_suffix);
       } else {
-        StringAppendF(
-            &report,
-            "\nSparse linear algebra library %15s %s\n",
-            SparseLinearAlgebraLibraryTypeToString(
-                sparse_linear_algebra_library_type),
-            mixed_precision_suffix);
+        StringAppendF(&report,
+                      "\nSparse linear algebra library %15s %s\n",
+                      SparseLinearAlgebraLibraryTypeToString(
+                          sparse_linear_algebra_library_type),
+                      mixed_precision_suffix);
       }
     }