commit 4bc100c13d3fa3a4524503dddf6b1dd40520d3bf
author Sergiu Deitsch <sergiu.deitsch@gmail.com> Sun Mar 06 14:15:25 2022 +0100
committer Alex Stewart <alexs.mac@gmail.com> Wed Mar 09 09:52:44 2022 +0000
tree e96da296f68228dcecbdfc5d5da6b363160807f7
parent e91995cce456d7edf404103bd3dc40794e13886e

Do not define unusable import targets

In the case, necessary properties of import targets cannot be set (i.e.,
either because the include directory or the library was found), do not
define import target to begin with.

Change-Id: Id216cd692a8ec240a20f65b174f196ddaa306c2b

cmake/FindCXSparse.cmake

diff --git a/cmake/FindCXSparse.cmake b/cmake/FindCXSparse.cmake
index 94a56b3..afd1ebf 100644
--- a/cmake/FindCXSparse.cmake
+++ b/cmake/FindCXSparse.cmake
@@ -228,7 +228,7 @@
   REQUIRED_VARS CXSparse_INCLUDE_DIR CXSparse_LIBRARY
   VERSION_VAR CXSparse_VERSION)
 
-if (CXSparse_FOUND)
+if (CXSparse_INCLUDE_DIR AND CXSparse_LIBRARY)
   if (NOT TARGET CXSparse::CXSparse)
     add_library (CXSparse::CXSparse IMPORTED UNKNOWN)
   endif (NOT TARGET CXSparse::CXSparse)
@@ -237,4 +237,4 @@
     IMPORTED_LOCATION ${CXSparse_LIBRARY})
   set_property (TARGET CXSparse::CXSparse PROPERTY
     INTERFACE_INCLUDE_DIRECTORIES ${CXSparse_INCLUDE_DIR})
-endif (CXSparse_FOUND)
+endif (CXSparse_INCLUDE_DIR AND CXSparse_LIBRARY)

cmake/FindSuiteSparse.cmake

diff --git a/cmake/FindSuiteSparse.cmake b/cmake/FindSuiteSparse.cmake
index 452ffa1..b54cea4 100644
--- a/cmake/FindSuiteSparse.cmake
+++ b/cmake/FindSuiteSparse.cmake
@@ -221,16 +221,6 @@
     if (SuiteSparse_${COMPONENT}_LIBRARY)
       message(STATUS "Found ${COMPONENT} library: ${SuiteSparse_${COMPONENT}_LIBRARY}")
       mark_as_advanced(SuiteSparse_${COMPONENT}_LIBRARY)
-
-      if(NOT TARGET SuiteSparse::${COMPONENT})
-        add_library(SuiteSparse::${COMPONENT} IMPORTED UNKNOWN)
-      endif()
-      set_property(TARGET SuiteSparse::${COMPONENT} PROPERTY
-        INTERFACE_INCLUDE_DIRECTORIES ${SuiteSparse_${COMPONENT}_INCLUDE_DIR})
-      set_property(TARGET SuiteSparse::${COMPONENT} PROPERTY
-        IMPORTED_LOCATION_RELEASE ${SuiteSparse_${COMPONENT}_LIBRARY})
-      set_property(TARGET SuiteSparse::${COMPONENT} APPEND PROPERTY
-        IMPORTED_CONFIGURATIONS RELEASE)
     else ()
       # Specified libraries not found.
       set(SuiteSparse_${COMPONENT}_FOUND FALSE)
@@ -245,6 +235,18 @@
       endif()
     endif()
   endif()
+
+  # Define the target only if the include directory and the library were found
+  if (SuiteSparse_${COMPONENT}_INCLUDE_DIR AND SuiteSparse_${COMPONENT}_LIBRARY)
+    if (NOT TARGET SuiteSparse::${COMPONENT})
+      add_library(SuiteSparse::${COMPONENT} IMPORTED UNKNOWN)
+    endif (NOT TARGET SuiteSparse::${COMPONENT})
+
+    set_property(TARGET SuiteSparse::${COMPONENT} PROPERTY
+      INTERFACE_INCLUDE_DIRECTORIES ${SuiteSparse_${COMPONENT}_INCLUDE_DIR})
+    set_property(TARGET SuiteSparse::${COMPONENT} PROPERTY
+      IMPORTED_LOCATION ${SuiteSparse_${COMPONENT}_LIBRARY})
+  endif (SuiteSparse_${COMPONENT}_INCLUDE_DIR AND SuiteSparse_${COMPONENT}_LIBRARY)
 endmacro()
 
 # Given the number of components of SuiteSparse, and to ensure that the