commit | 660af905fbefc15c54ae2f82bde452a0254881c6 | [log] [tgz] |
---|---|---|
author | Sameer Agarwal <sameeragarwal@google.com> | Mon Sep 19 06:25:18 2022 -0700 |
committer | Sameer Agarwal <sameeragarwal@google.com> | Mon Sep 19 07:53:27 2022 -0700 |
tree | fd235f1825a41901e9a3fafe3fd3a0825b52a141 | |
parent | 4cd257cf4ac8b0b81ab76b5dbac53b2b01de885e [diff] |
Fix a bug in TrustRegionMinimizer. The value of x_norm_ was computed and then incorrectly set to -1. This meant that ParameterToleranceReached was using the incorrect value till such time as the minimizer made its first successful step. This change removes the member variable and just computes the norm of x inside ParameterToleranceReached. Fixes https://github.com/ceres-solver/ceres-solver/issues/885 Thanks to Anton Adanasyev for reporting this. Change-Id: Ib4d52a45c2d925557ce2c5b57de8a9fa37da6c70
Ceres Solver is an open source C++ library for modeling and solving large, complicated optimization problems. It is a feature rich, mature and performant library which has been used in production at Google since 2010. Ceres Solver can solve two kinds of problems.
Please see ceres-solver.org for more information.