| commit | d6a93100981ab0dbe329c94db06b89ca3cf0860c | [log] [tgz] |
|---|---|---|
| author | Sameer Agarwal <sameeragarwal@google.com> | Tue Nov 01 10:46:50 2022 -0700 |
| committer | Sameer Agarwal <sameeragarwal@google.com> | Tue Nov 01 10:46:50 2022 -0700 |
| tree | 68ceef8146c1cfef57ba34e720ed16bc2b7dd1de | |
| parent | 9364e31ee8dacbdd2c1689c4f74c291c5d7000f0 [diff] |
Clang Tidy Fixes Change-Id: I65558225cc537e86428caa5081bde165968bfab3
diff --git a/internal/ceres/block_sparse_matrix.cc b/internal/ceres/block_sparse_matrix.cc index 0e05693..053b3c0 100644 --- a/internal/ceres/block_sparse_matrix.cc +++ b/internal/ceres/block_sparse_matrix.cc
@@ -48,7 +48,7 @@ namespace { void ComputeCumulativeNumberOfNonZeros(std::vector<CompressedList>& rows) { - if (!rows.size()) { + if (rows.empty()) { return; } rows[0].cumulative_nnz = rows[0].nnz;
diff --git a/internal/ceres/block_sparse_matrix_test.cc b/internal/ceres/block_sparse_matrix_test.cc index 62bb0f4..cfed041 100644 --- a/internal/ceres/block_sparse_matrix_test.cc +++ b/internal/ceres/block_sparse_matrix_test.cc
@@ -30,8 +30,11 @@ #include "ceres/block_sparse_matrix.h" +#include <algorithm> #include <memory> +#include <random> #include <string> +#include <vector> #include "ceres/casts.h" #include "ceres/crs_matrix.h"
diff --git a/internal/ceres/evaluation_benchmark.cc b/internal/ceres/evaluation_benchmark.cc index 1fdc8d2..b18f563 100644 --- a/internal/ceres/evaluation_benchmark.cc +++ b/internal/ceres/evaluation_benchmark.cc
@@ -29,6 +29,7 @@ // Authors: dmitriy.korchemkin@gmail.com (Dmitriy Korchemkin) #include <memory> +#include <random> #include <string> #include <vector>