commit d9a3dfbf2070eb8a020424552b0f2dd12222825d
author Sameer Agarwal <sameeragarwal@google.com> Thu Jul 14 06:56:58 2022 -0700
committer Sameer Agarwal <sameeragarwal@google.com> Thu Jul 14 06:58:49 2022 -0700
tree 99c50915762a975b07b23ce357699431267ecb70
parent 5bd43a1fa486690086e149cc502397f3a532c2be

Add a missing ifdef guard to dense_cholesky_test

Change-Id: Ibd924bc52b589ea70c5e7a543e1092697a0e5941

internal/ceres/dense_cholesky_test.cc

diff --git a/internal/ceres/dense_cholesky_test.cc b/internal/ceres/dense_cholesky_test.cc
index a425343..e513641 100644
--- a/internal/ceres/dense_cholesky_test.cc
+++ b/internal/ceres/dense_cholesky_test.cc
@@ -45,9 +45,7 @@
 
 namespace ceres::internal {
 
-
-using Param =
-    ::testing::tuple<DenseLinearAlgebraLibraryType, bool>;
+using Param = ::testing::tuple<DenseLinearAlgebraLibraryType, bool>;
 constexpr bool kMixedPrecision = true;
 constexpr bool kFullPrecision = false;
 
@@ -109,70 +107,65 @@
   }
 }
 
-INSTANTIATE_TEST_SUITE_P(
-    EigenCholesky,
-    DenseCholeskyTest,
-    ::testing::Combine(::testing::Values(EIGEN),
-                       ::testing::Values(kFullPrecision)),
-    ParamInfoToString);
+INSTANTIATE_TEST_SUITE_P(EigenCholesky,
+                         DenseCholeskyTest,
+                         ::testing::Combine(::testing::Values(EIGEN),
+                                            ::testing::Values(kFullPrecision)),
+                         ParamInfoToString);
 #ifndef CERES_NO_LAPACK
-INSTANTIATE_TEST_SUITE_P(
-    LapackCholesky,
-    DenseCholeskyTest,
-    ::testing::Combine(::testing::Values(LAPACK),
-                       ::testing::Values(kFullPrecision)),
-    ParamInfoToString);
+INSTANTIATE_TEST_SUITE_P(LapackCholesky,
+                         DenseCholeskyTest,
+                         ::testing::Combine(::testing::Values(LAPACK),
+                                            ::testing::Values(kFullPrecision)),
+                         ParamInfoToString);
 #endif
 #ifndef CERES_NO_CUDA
-INSTANTIATE_TEST_SUITE_P(
-    CudaCholesky,
-    DenseCholeskyTest,
-    ::testing::Combine(::testing::Values(CUDA),
-                       ::testing::Values(kMixedPrecision,
-                                         kFullPrecision)),
-    ParamInfoToString);
+INSTANTIATE_TEST_SUITE_P(CudaCholesky,
+                         DenseCholeskyTest,
+                         ::testing::Combine(::testing::Values(CUDA),
+                                            ::testing::Values(kMixedPrecision,
+                                                              kFullPrecision)),
+                         ParamInfoToString);
 #endif
 
+#ifndef CERES_NO_CUDA
 TEST(DenseCholesky, ValidMixedPrecisionOptions) {
-#ifndef CERES_NO_CUDA
-  {
-    // Dense Cholesky with CUDA: okay, supported.
-    ContextImpl context;
-    LinearSolver::Options options;
-    options.dense_linear_algebra_library_type = CUDA;
-    options.use_mixed_precision_solves = true;
-    options.context = &context;
-    std::unique_ptr<DenseCholesky> dense_cholesky =
-        DenseCholesky::Create(options);
-    EXPECT_NE(dense_cholesky, nullptr);
-  }
+  // Dense Cholesky with CUDA: okay, supported.
+  ContextImpl context;
+  LinearSolver::Options options;
+  options.dense_linear_algebra_library_type = CUDA;
+  options.use_mixed_precision_solves = true;
+  options.context = &context;
+  std::unique_ptr<DenseCholesky> dense_cholesky =
+      DenseCholesky::Create(options);
+  EXPECT_NE(dense_cholesky, nullptr);
+}
 #endif
+
+TEST(DenseCholesky, InvalidMixedPrecisionOptionsEigen) {
+  // Dense Cholesky with Eigen: not supported
+  ContextImpl context;
+  LinearSolver::Options options;
+  options.dense_linear_algebra_library_type = EIGEN;
+  options.use_mixed_precision_solves = true;
+  options.context = &context;
+  std::unique_ptr<DenseCholesky> dense_cholesky =
+      DenseCholesky::Create(options);
+  EXPECT_EQ(dense_cholesky, nullptr);
 }
 
-TEST(DenseCholesky, InvalidMixedPrecisionOptions) {
-  {
-    // Dense Cholesky with Eigen: not supported
-    ContextImpl context;
-    LinearSolver::Options options;
-    options.dense_linear_algebra_library_type = EIGEN;
-    options.use_mixed_precision_solves = true;
-    options.context = &context;
-    std::unique_ptr<DenseCholesky> dense_cholesky =
-        DenseCholesky::Create(options);
-    EXPECT_EQ(dense_cholesky, nullptr);
-  }
-
-  {
-    // Dense Cholesky with Lapack: not supported
-    ContextImpl context;
-    LinearSolver::Options options;
-    options.dense_linear_algebra_library_type = LAPACK;
-    options.use_mixed_precision_solves = true;
-    options.context = &context;
-    std::unique_ptr<DenseCholesky> dense_cholesky =
-        DenseCholesky::Create(options);
-    EXPECT_EQ(dense_cholesky, nullptr);
-  }
+#ifndef CERES_NO_LAPACK
+TEST(DenseCholesky, InvalidMixedPrecisionOptionsLAPACK) {
+  // Dense Cholesky with Lapack: not supported
+  ContextImpl context;
+  LinearSolver::Options options;
+  options.dense_linear_algebra_library_type = LAPACK;
+  options.use_mixed_precision_solves = true;
+  options.context = &context;
+  std::unique_ptr<DenseCholesky> dense_cholesky =
+      DenseCholesky::Create(options);
+  EXPECT_EQ(dense_cholesky, nullptr);
 }
+#endif
 
 }  // namespace ceres::internal