Google Git
Sign in
ceres-solver / ceres-solver / e9eb8a324e8a5c58bf5cf15fb0706f78444cd895
commite9eb8a324e8a5c58bf5cf15fb0706f78444cd895[log] [tgz]
authorSameer Agarwal <sameeragarwal@google.com>Sun Mar 19 00:34:22 2017 -0700
committerSameer Agarwal <sameeragarwal@google.com>Sun Mar 19 00:38:01 2017 -0700
tree02ef289090b8f84e22e6e3885cb2e024e43b0bb5
parentaf3b9394ea577165bedd81315c6a9998fd91c6e5 [diff]
Fix when LineSearchMinimizer adds the IterationSummary to Solver::Summary

Previously, even when an iteration was successful, the LineSearchMinimizer
would only add the iteration summary to the Summary object if none
of the convergence tests were passed. This could cause iterations with
significant progress in the last iteration to be mis-reported.

The solution would be correct, but the actual cost would be misreported.

This change changes the order of these operations and ensures that
the iteration summary is added whenever the iteration itself is successful.

Thanks to Daniel Weindl for reporting this.

Change-Id: Iff10eccb49d50ad28127f44e149c17fa466db4ae
1 file changed
tree: 02ef289090b8f84e22e6e3885cb2e024e43b0bb5
  1. cmake/
  2. config/
  3. data/
  4. docs/
  5. examples/
  6. include/
  7. internal/
  8. jni/
  9. scripts/
  10. .gitignore
  11. CMakeLists.txt
  12. LICENSE
  13. package.xml
  14. README.md
README.md

Ceres Solver

Ceres Solver is an open source C++ library for modeling and solving large, complicated optimization problems. It is a feature rich, mature and performant library which has been used in production at Google since 2010. Ceres Solver can solve two kinds of problems.

  1. Non-linear Least Squares problems with bounds constraints.
  2. General unconstrained optimization problems.

Please see ceres-solver.org for more information.

WARNING - Do not make GitHub pull requests!

Ceres development happens on Gerrit, including both repository hosting and code reviews. The GitHub Repository is a continuously updated mirror which is primarily meant for issue tracking. Please see our Contributing to Ceres Guide for more details.

The upstream Gerrit repository is

https://ceres-solver.googlesource.com/ceres-solver