commit 3ff12a878bf335dd3ea15944fe20648757c1bad8
author Sameer Agarwal <sameeragarwal@google.com> Mon Apr 29 11:16:09 2019 -0700
committer Sameer Agarwal <sameeragarwal@google.com> Mon Apr 29 11:16:09 2019 -0700
tree 6e1879c8be5fb4884113bed851e46d7df4037179
parent 57441fe909e53478cf3371973f865206ec025d73

Fix a clang-tidy warning in problem_test.cc

Change-Id: Iaf26db5711c13e802123a4de724c0445eec884f9

internal/ceres/problem_test.cc

diff --git a/internal/ceres/problem_test.cc b/internal/ceres/problem_test.cc
index 3613dd6..986d13d 100644
--- a/internal/ceres/problem_test.cc
+++ b/internal/ceres/problem_test.cc
@@ -1551,7 +1551,7 @@
  public:
   static constexpr bool kApplyLossFunction = true;
   static constexpr bool kDoNotApplyLossFunction = false;
-  static double kLossFunctionScale;
+  static double loss_function_scale_;
 
  protected:
   ProblemImpl problem_;
@@ -1559,7 +1559,7 @@
   double y_[3] = {1, 2, 3};
 };
 
-double ProblemEvaluateResidualBlockTest::kLossFunctionScale = 2.0;
+double ProblemEvaluateResidualBlockTest::loss_function_scale_ = 2.0;
 
 TEST_F(ProblemEvaluateResidualBlockTest,
        OneResidualBlockNoLossFunctionFullEval) {
@@ -1714,13 +1714,13 @@
                                 y_);
   Vector expected_f(5);
   expected_f << 1, 2, 1, 2, 3;
-  expected_f *= std::sqrt(kLossFunctionScale);
+  expected_f *= std::sqrt(loss_function_scale_);
   Matrix expected_dfdx = Matrix::Zero(5, 2);
   expected_dfdx.block(0, 0, 2, 2) = Matrix::Identity(2, 2);
-  expected_dfdx *= std::sqrt(kLossFunctionScale);
+  expected_dfdx *= std::sqrt(loss_function_scale_);
   Matrix expected_dfdy = Matrix::Zero(5, 3);
   expected_dfdy.block(2, 0, 3, 3) = Matrix::Identity(3, 3);
-  expected_dfdy *= std::sqrt(kLossFunctionScale);
+  expected_dfdy *= std::sqrt(loss_function_scale_);
   double expected_cost = expected_f.squaredNorm() / 2.0;
 
   double actual_cost;